ShoroukAziz / Beautify-Anki

An Anki addon that attempts to give Anki's deck browser and deck overview pages a material design look.
http://beautify-anki.shorouk.dev/
GNU Affero General Public License v3.0
151 stars 15 forks source link

v0.3.2 - potential bugs - differences between previous version for Anki 2.1.22- 2.1.26 #44

Open cereska opened 4 years ago

cereska commented 4 years ago

Hey, as per your request on Reddit, I'm gonna list here all tiny differences I noticed while comparing this version against the last published one. I'll let you triage them and decide if you want to treat them as bugs or as a expected feature. I've decided to put it all as one bug as not to swamp you, which I hope is okay. Majority of the items is minor, I'd even say cosmetic :)

Item 1 The font color for the circular diagram has changed to orange, which makes it less readable. Before & After: image

Item 2 The font color of the review button has changed to black, imho the earlier white was nicer/more readable image

Item 3 On the deck summary, each column listing number of cards (new/to review) used to be centered, now it's left aligned. Imho centered was better :) image

Item 4 In the deck summary, all rows for decks and subdecks used to have equal height. Now, as you can see as per screeen in item 3, the very first row has some extra padding on the top (or maybe it's an rendered empty header row?), which looks a little off.

Tested on: Win 10 Pro Resolution 2560x1440 and 4k Anki Version 2.1.35 (84dcaa86) with Python 3.8.0 Qt 5.14.2 PyQt 5.14.2

Debug info

Anki 2.1.35 (84dcaa86) Python 3.8.0 Qt 5.14.2 PyQt 5.14.2
Platform: Windows 10
Flags: frz=True ao=True sv=1
Add-ons, last update check: 2020-10-29 14:01:55

===Add-ons (active)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
'' ['BeautifyAnki', 0, 'None', mod]
AnkiWebView Inspector ['31746032', 2019-05-03T00:43, 'None', '']
AwesomeTTS - Add speech to your flashcards ['1436550454', 2020-10-29T15:13, 'None', '']
Beautify Anki Material design  Deck Background and icon  ['1150874988', 2020-05-31T02:53, 'None', '']
Hierarchical Tags 2 ['594329229', 2020-04-11T18:36, 'None', '']
Korean Support ['1336389630', 2020-04-14T17:22, 'None', mod]
Mini Format Pack ['295889520', 2018-07-24T19:45, 'None', '']
Quizlet to Anki 21 Importer with audio support ['1362209126', 2020-09-10T19:28, 'None', '']
Resize images in editor ['1103084694', 2020-08-02T15:04, 'None', mod]
Review Heatmap ['review_heatmap', 2020-04-30T15:23, 'None', '']
True Retention by Card Maturity ['923360400', 2017-08-29T21:00, 'None', '']
right hand reviews  hjkl answer shortcuts  Handy Answer Keys configurable ['850294128', 2019-12-22T00:40, 'None', '']

===IDs of active AnkiWeb add-ons===
1103084694 1150874988 1336389630 1362209126 1436550454 295889520 31746032 594329229 850294128 923360400

===Add-ons (inactive)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
True Retention ['613684242', 2017-11-19T21:43, 'None', '']

Love this addon and thank you for all your hard work!

ShoroukAziz commented 4 years ago

Item 1 You can change that color from the theme file to whatever you like


"PIE-CHART":{
"wedgits-font-color" : "rgba(255, 255, 255,1)"
}

> 
> **Item 2**

I agree with you. I'll either bring it back to white or add an option to choose your own color

> **Item 3**
Also, agree and will fix it
> 
> **Item 4**
The empty space at the top is there in order to enable the dragging and dropping back. I'll see if there's a way around it though but I don't think so.

-------------
Thank you so much for your feedback I really appreciate it!
cereska commented 4 years ago

Hey, thanks for your response.

Re Item 1, I have applied the change in the theme settings, however this impacts the whole widget: image So by changing font to be white on the diagram, the legend is now white font color on white semi-transparent background. If you take a closer look at the previous version, white text color was for Unseen, Mature and propably Suspended on the diagram, while black text color was for the Young cards on the diagram and the legend below diagram. Would it be possible to put it back like that? Or at least add a separate config entry for the legend area, so that it can stay black while the diagram font is white?

Re Item 4 Adding .decks-container .top-level-drag-row.ui-droppable { line-height: 0px; } to deckbrowser.css does the trick, while dragging & dropping still works :)

cereska commented 4 years ago

Item 5 This would perhaps look better styled as one panel instead of three separate ones imho: image

Item 6 I noticed that the background position is different on main screen vs deck summary screen. While on main app screen it is cover, on deck summary screen, instead of scaling, it repeats on y-axis.