ShoroukAziz / Beautify-Anki

An Anki addon that attempts to give Anki's deck browser and deck overview pages a material design look.
http://beautify-anki.shorouk.dev/
GNU Affero General Public License v3.0
149 stars 14 forks source link

Fix Beautify Anki in latest Anki version (2.1.49) #59

Closed fylux closed 2 years ago

fylux commented 2 years ago

I have tried fix the add-on by simply spotting what part of the code was crashing and fixing it accordingly. I could trigger 3 different crashes and they were fixed in the following ways:

Overall, these are very hacky fixes because in ankitects/anki@e568525 most of the logic that this add-on uses was rewritten so to fix the add-on further a complete rewrite would be required. It might be that there are more crashes which this fix does not cover since I was the only tester.

Tested locally on Windows 10, Anki 2.1.49.

PS: Thanks to @datphan310 for the reviewer.py fix. Before I was just naively commenting the code.

ShoroukAziz commented 2 years ago

Thanks a lot @fylux For your contribution. That seems to fix it for now.

fylux commented 2 years ago

Thank you very much for the review! Please don't forget to generate a new github release including this patch.

ShoroukAziz commented 2 years ago

Done already. Thanks Again!