ShoroukAziz / Beautify-Anki

An Anki addon that attempts to give Anki's deck browser and deck overview pages a material design look.
http://beautify-anki.shorouk.dev/
GNU Affero General Public License v3.0
149 stars 15 forks source link

visual issue #66

Open AkiraRy opened 1 year ago

AkiraRy commented 1 year ago

Знімок екрана 2023-01-14 091734

Can i somehow change this white bar at the bottom? Too annoying in night mode. Seems like an unchangable value, i tried changing color in other themes but again i`ve got this issue. (theme:starry)

Tokukarin commented 1 year ago

Do you want it to look like this? image

Tokukarin commented 1 year ago

I fixed it and made a pull request.

Funny story: I did not even notice that white bar before you mentioned it, but after seeing it I could not unsee it and had to fix it... THANK YOU FOR THAT! 😠😡

Tokukarin commented 1 year ago

For everyone subscribed, you can use the release of my fork for the time being: https://github.com/Tokukarin/Beautify-Anki

AkiraRy commented 1 year ago

You`re welcome, thank you for fix

Tokukarin commented 1 year ago

No problem, the author declined my pull request so this fix won't be implemented in this repository. So for everyone else: Check out my fork

Edit: Nevermind the pull request was closed from github, gonna reissue the pull request. Still my fork has also fixes for the Heatmap.

AkiraRy commented 1 year ago

No problem, the author declined my pull request so this fix won't be implemented in this repository. So for everyone else: Check out my fork

I have one question, if ive already have this addon, how to implement your changes? just simply change this file "user_files/assets/css/bootstrap.min.css" to yours?`

Tokukarin commented 1 year ago

@2DLuffy Yes, the bootstrap one for the bar at the bottom. If you also want the fix for the nightmode issue then you would also need this ones: deckbrowser.css & reviewer_bottom.css

Edit: Best practice would be renaming bootstrap.min.css to bootstrap.min.css.bak and then moving my edited one in there.

AkiraRy commented 1 year ago

Ok i will do as you say. (dark text fixed with help of 1 youtube channel)

Tokukarin commented 1 year ago

You know where I am If you need help :D

AkiraRy commented 1 year ago

As issue was fixed i`ll close

Tokukarin commented 1 year ago

@2DLuffy So it went fine?

AkiraRy commented 1 year ago

yup perfectly 👌

AkiraRy commented 1 year ago

it's so great feels like i`m in full screen mode xd

Tokukarin commented 1 year ago

yup perfectly ok_hand

Could you be so kind as to give me the Anki version your using? As well as the Python version (QT 5 or QT 6)? :smile:

AkiraRy commented 1 year ago

Version ⁨2.1.54 (b6a7760c)⁩ Python 3.9.7 Qt 5.15.2 PyQt 5.15.5 (from Anki->Help->About)

Tokukarin commented 1 year ago

Version ⁨2.1.54 (b6a7760c)⁩ Python 3.9.7 Qt 5.15.2 PyQt 5.15.5 (from Anki->Help)

Thank you very much! I am also using 2.1.54 :laughing: But the QT6 version.

But thank you, this means it's also working on the QT5 Version, that's good to know!

AkiraRy commented 1 year ago

Heard that QT6 has a lot of bugs : >

Tokukarin commented 1 year ago

Yeah lemme tell you something...

On QT5 I have no GUI, it's completely empty BUT one of my addons only works on QT5 On QT6 The GUI works but not the addon I am using. :cry: :gun:

AkiraRy commented 1 year ago

@Tokukarin Ohh ... It`s changed many visual things including font-size, text-placing, maybe it was your personal preferences. Is there a way only to fix this white line at the bottom(specific code part)

Tokukarin commented 1 year ago

@2DLuffy No, it should only change the white line, I did not change font's.

AkiraRy commented 1 year ago

i`ll provide image of changes this is with your .css file Screenshot 2023-03-17 230147 this is previous image

(if you need I can also include my .css file)

Tokukarin commented 1 year ago

@2DLuffy I was able to replicate this on QT5, I also think I fixed it, give me max 5 minutes for testing then I will release a fix.

AkiraRy commented 1 year ago

I`ll twst it as well after your release

Tokukarin commented 1 year ago

@2DLuffy The fix is on my fork. Edit: Let me know If it works.

AkiraRy commented 1 year ago

Now i don`t see any issue 👍

Tokukarin commented 1 year ago

Now i don`t see any issue +1

You forgot the "yet" there is always a yet..... :laughing:

Keep me up to date If something else is broken.

AkiraRy commented 1 year ago

yup like this text but now i got used to it xd image

AkiraRy commented 1 year ago

seems like only date has flexible text, that can change format due to resize, but all other changes only their size and are fixed to a particular place in class-container(aka new, learning, cards so on)

Tokukarin commented 1 year ago

Mhh image

AkiraRy commented 1 year ago

well if i zoom in a little bit it`ll be ok, maybe I need to change smth in settings

Tokukarin commented 1 year ago

I can't replicate this.

Are you using any other addons? Did you change something in the config file? (Like the theme?)

Tokukarin commented 1 year ago

You forgot the "yet" there is always a yet.....

It hurts to be right :hurtrealbad:

AkiraRy commented 1 year ago

I can't replicate this.

Are you using any other addons? Did you change something in the config file? (Like the theme?)

changed background and icon images, also font-family for beatify-anki I think thats it Edited: also this "https://github.com/ShoroukAziz/Beautify-Anki/issues/60"

Tokukarin commented 1 year ago

You changed the font-family in the .json file? If yes then please send me a copy of it.

AkiraRy commented 1 year ago

first of all i've checked what option do i have from here "C:\Users\User\AppData\Roaming\Anki2\addons21\Beautify-anki\user_files\assets\fonts" and then changed it in my theme stary.json file (idk why but git doesn`t allow me to send .json files, i can send you gdrive link)

Tokukarin commented 1 year ago

You can also post it in clear text: `"overlay-color1" : "rgba(41, 41, 43,0.3)", "overlay-color2" : "rgba(41, 41, 43,0.3)", "heatmap-background":true,

"gear-icon-color"   :" rgba(171, 189, 198,1)",
"buttons-color"     : "rgba(66, 66, 66,1)",
"buttons-label-color"  : "rgba(255, 255, 255,1)", 
"bottombar-color"   : "rgba(47, 47, 49,1)",
"topbar-color"      : "rgba(66, 66, 66,1)",
"topbar-position"   : "center",`

Nevermind this is bugged

AkiraRy commented 1 year ago

"{

"overlay-color1"    : "rgba(41, 41, 43,0.8)",
"overlay-color2"    : "rgba(41, 41, 43,0.8)",
"heatmap-background":true,

"gear-icon-color"   :" rgba(171, 189, 198,1)",
"buttons-color"     : "rgba(66, 66, 66,1)",
"buttons-label-color"  : "rgba(255, 255, 255,1)", 
"bottombar-color"   : "rgba(47, 47, 49,1)",
"topbar-color"      : "rgba(66, 66, 66,1)",
"topbar-position"   : "left",

"large-areas-color"     : "rgba(56, 56, 58 , 0.7) ",
"decks-border-color"    : "rgba(56, 56, 58 , 1) ",
"decks-font-color"      : "rgba(255,255,255,1)",
"decks-font-size"        :"13px",
"decks-font-family"        :"inherit",
"decks-font-src"        :"",

"filtered-deck-color"   : "rgba(130, 187, 240,1)",
"DECK-BROWSER": {

    "review-count-background-color" : " rgba(76, 175, 80,1)",
    "review-count-color" : "rgb(255, 255, 255,1)",
    "new-count-background-color" : "rgba(63, 81, 181,1)",
    "new-count-color" : "rgb(255, 255, 255,1)",

    "wedgits-font-size"     :"13px",
    "wedgits-font-family"   :"Handlee",
    "wedgits-font-src"      :"Handlee.ttf",
    "wedgits-font-color" : "rgba(238, 238, 238,1)" ,

    "overview-wedgit-bg"    : "rgba(0, 96, 100,1)" ,
    "average-wedgit-bg"     : "rgba(136, 14, 79,1)" ,
    "remaining-wedgit-bg"   : "rgba(183, 28, 28,1)" ,
    "new-wedgit-bg"         : "rgba(13, 71, 161,1)" ,
    "due-wedgit-bg"         : "rgba(27, 94, 32,1)" ,
    "total-wedgit-bg"       : "rgba(74, 20, 140,1)" 

} ,
"DECK-OVERVIEW" :{

    "deck-name-font-size":"70px",
    "deck-name-font-family":"fantasy",
    "deck-name-font-src"        :"",

    "wedgits-font-size"     :"13px",
    "wedgits-font-family"   :"Handlee",
    "wedgits-font-src"      :"Handlee.ttf",
    "wedgits-font-color"    : "rgba(255, 255, 255,1)",

    "total-notes-wedgit-bg" : "rgba(0, 96, 100,1)" ,
    "remaining-wedgit-bg"   : "rgba(245, 127, 23,1)" ,
    "new-wedgit-bg"         : "rgba(1, 87, 155,1)" ,
    "learning-wedgit-bg"    : "rgba(191, 54, 12,1)" ,
    "review-wedgit-bg"      : "rgba(27, 94, 32,1)" ,
    "total-wedgit-bg"       : "rgba(49, 27, 146,1)" ,

"PIE-CHART":{
    "wedgits-font-color" : "rgba(255, 255, 255,1)"

}
}

} "

Tokukarin commented 1 year ago

Thanks image It's time to get my mac out, because your config file is working for me....

AkiraRy commented 1 year ago

but not for me 🤣

Tokukarin commented 1 year ago

Your config doesn't even load on mac, on linux it does, but I saw that there could be something wrong in the config you sent me, I am gonna troubleshoot it and send you a modified version.

Tokukarin commented 1 year ago

-

AkiraRy commented 1 year ago

sure, but these files are identical (github and starry) so no changes.

Also i think this file starry.json can`t change any position of widgets except their color, font, size

Tokukarin commented 1 year ago

@2DLuffy Okay, I made a final change, please download V.1.2.1 and test this one.

If that doesn't work, then I am out of ideas.