search

Short-io / qreator

QR Code generator: browser/node.js, transparency, logo, border-radius, opacity, PNG/SVG/PDF
MIT License
22 stars 5 forks source link

Add ability to set module-level spacings #17

Closed kostia1st closed 1 month ago

kostia1st commented 2 months ago

I want to have an option to produce a little bit spicier QR code.

There is a number of things that could be done to the current implementation, but currently I wanted to focus on the "module spacing" effect.

Simplistic implementation of the said effect looks like this chrome_iCwcf2p44x This QR has an issue though - it does not get recognized, at least by my phone (S24).

However, once you draw the "finders" as whole things without spacings between modules, it starts working OK (this is a very loose manually edited image from above) chrome_dFWySk3M11

I think that the rendering of the "finders" and of the rest of the QR should be separated and potentially be done differently.

@gugu So if you're OK with that direction, I might submit a PR at some point later, with "spacing" and maybe some other effects.

gugu commented 2 months ago

Yes, I agree. It is in my plan, but I am focused on other company-related tasks

gugu commented 1 month ago

Fixed in v9.5.0