ShotgunNinja / Kerbalism

Hundreds of Kerbals were killed in the making of this mod.
The Unlicense
43 stars 19 forks source link

Support for SSTU #117

Closed Maxzhao1999 closed 7 years ago

Maxzhao1999 commented 7 years ago

Sorry that I've made a issue tracker with the exact same topic. I'm meaning to use pull request. The patch needs a lot of work though.

I've started making a patch for SSTU. I'd like to hear your suggestion as this is a fairly big mod and my modding experience is very limited.

Currently, the patch only includes the fuel cells which is included in the Class-E Shuttle and the HG antenna. For the fuel cell, I've noticed that the whole life support system on the shuttle requires around 8.5 EC/s to run. Since the actual shuttle gets all its electricity from the fuel cell I've decided to give it a capacity of 20 (10 EC/s). This has been tested and works fairly well. For the HGA however, I've failed to make it work. Would love it if you can take a look.

Also, although the SSTU uses its own moduelSSTUSolarPanel, its interaction with electric charge is detected by Kerbalism already so not much has to be done there.

I've also noticed that in SSTU the class-E docking port also has a crew capacity of one, Kerbalism thus has given it its own scrubber and pressure control. Can I assume that you're happy with this staying unchanged?

PiezPiedPy commented 7 years ago

Needs an } on line 26 ;)