ShotgunNinja / Kerbalism

Hundreds of Kerbals were killed in the making of this mod.
The Unlicense
43 stars 19 forks source link

No more H2 and O2 dumping during electrolysis #147

Open basilicofresco opened 6 years ago

basilicofresco commented 6 years ago

When hydrogen or oxygen tanks are full now the electrolysis should stop in order to avoid unnecessary water disintegration.

lordcirth commented 6 years ago

This is an interesting question. The user-desired behaviour depends on why they are running electrolysis. If they are trying to store EC by splitting water in fuel for a fuel cell, they don't want to dump either one. If they are trying to convert water into oxygen to breathe, they may not even have hydrogen storage, and this patch would prevent this use case. Is it possible to set hydrogen to dump, and oxygen to not dump?

basilicofresco commented 6 years ago

Well, you are right. In order to discard hydrogen when there is no left space you just have to write "dump = hydrogen" instead of "dump = false".

At this point I wonder if two different electrolysis processes could be useful. Just imagine: