search

ShotgunNinja / Kerbalism

Hundreds of Kerbals were killed in the making of this mod.
The Unlicense
43 stars 19 forks source link

Signal and debris #23

Closed nasuellia closed 8 years ago

nasuellia commented 8 years ago

Categorizing a Vessel as Debris lets you command it despite total lack of signal.

ShotgunNinja commented 8 years ago

Setting a vessel as Debris will in fact disable all of this mod mechanics and the background simulation. The reason for this is that it is the cheaper way to detect 'debris-like' vessels. The correct alternative is to scan every vessel for a command module, but that is too costly to do at 50hz for all existing vessels.

lordcirth commented 8 years ago

Makes sense for background craft, but why not check when focusing the debris? Doesn't cost much then.

ShotgunNinja commented 8 years ago

I could do that in the case of signal locks, actually. Not for the other mechanics else I lose coherency between loaded and unloaded vessels behaviour.

nasuellia commented 8 years ago

Your our decision of skipping checks on debris is perfectly understandable and I think it's a good one, but lordcirth's idea to perform a single on focus check, with the sole purpose of avoiding exploitable tricks about signal is a great one.

ShotgunNinja commented 8 years ago

In next version, unmanned vessels flagged as debris are assumed to be without link and control is disabled for them.

More proper ways lead to inconsistencies between loaded and unloaded vessel behaviour, as the signal networks change depending on what vessel is active.

In future I will reconsider the way debris-like vessels are detected and probably perform a deep scan of the vessel modules and cache the results between simulation steps.

ShotgunNinja commented 8 years ago

this is in 0.9.9.9