search

ShoufaChen / DiffusionDet

[ICCV2023 Best Paper Finalist] PyTorch implementation of DiffusionDet (https://arxiv.org/abs/2211.09788)
Other
2.1k stars 162 forks source link

DDIM sampling eta setting #48

Open pinecho opened 1 year ago

pinecho commented 1 year ago

Hi, thanks for your great work. I noticed that you applied DDIM sampling method in your code, with the setting: https://github.com/ShoufaChen/DiffusionDet/blob/1efb36d4b0b721f2d509bc72656235a94d73ab02/diffusiondet/detector.py#L97

I found ETA controls the scale of the variance (0 is DDIM, and 1 is one type of DDPM). from https://github.com/ermongroup/ddim It seems that eta=1 means DDPM. May I ask if your eta is the same as the one from ermongroup?

ShoufaChen commented 1 year ago

Hi,

Thanks for your interest.

We have experimented with several eta values. The results demonstrate that eta has negligible influence on the final results. Therefore, we adopt ddim_sampling_eta = 1. as our default setting.