Shougo / ddc-source-lsp

lsp source for ddc.vim
Other
66 stars 20 forks source link

Improve creation of word from snippet items #34

Closed matsui54 closed 2 years ago

matsui54 commented 2 years ago

problem

When the lsp item has snippet textEdit, the source inserts CompletionItem.label, which is sometimes invalid to insert.

solution

Create word from insertText or textEdit.newText. This is the same way as vim-lsp or nvim-cmp. Of course, I took the past problems of creating word like #25 into consideration.

screenshot

before ddc-nvim-lsp_pr2

@snippet-expantion ddc-nvim-lsp_pr2_fixed

Shougo commented 2 years ago

Thank you