Shougo / ddc-source-lsp

lsp source for ddc.vim
Other
66 stars 20 forks source link

Add a new source parameter: `snippetIndicator` #48

Closed 110y closed 1 year ago

110y commented 1 year ago

What

Why

With recent (huge 👏) updates, now ddc-source-nvim-lsp adds an indicator string: ~, to snippet completion candidates. While it should work well for the majority of users, I think there might be a user who wants to change this string (in my case, I just want to remove ~).

Given that, this PR adds a new source parameter named snippetIndicator that enables us to change the indicator string for snippet completion candidates to an arbitrary string (including an empty string).

uga-rosa commented 1 year ago

deno task pre-commit is available to perform the local equivalent of a CI check.

110y commented 1 year ago

Thank you for your review! Let me fix it...

110y commented 1 year ago

@Shougo @uga-rosa

Sorry for the delay, I just handled all of your review comments. I appreciate it if you could take another look 🙏

uga-rosa commented 1 year ago

@Shougo please re-check

110y commented 1 year ago

Thanks a lot!