Shougo / ddc-source-lsp

lsp source for ddc.vim
Other
66 stars 20 forks source link

Fix inconsistent return value of request function #62

Closed k-86 closed 2 months ago

k-86 commented 2 months ago

When lspEngine==nvim-lsp && opt.sync==true, the request function in request.ts returns response: {err?: lsp.ResponseError, result: unknown}. Otherwise, it returns response.result: unknown.

By unifying the return value to response.result: unknown, Source.#resolve will work when lspEngine==lspoints.

Note: When lspEngine==vim-lsp, Source.#resolve does not work due to another problem.

Shougo commented 2 months ago

Thanks.

Shougo commented 2 months ago

It does not fix https://github.com/Shougo/ddc-source-lsp/issues/61 problem?