search

Shougo / ddc-ui-inline

Inline UI for ddc.vim
MIT License
4 stars 1 forks source link

UI overlapping #2

Closed phgz closed 1 year ago

phgz commented 1 year ago

Ubuntu 20.04.5 or MacOS 13.0.1 NVIM v0.9.0-dev-465+ga505c1acc See minimal.txt file for reproduction with packages and settings.

Using ddc#custom#patch_global('ui', 'inline') conflicts with other ui invoked with ddc#map#manual_complete (ex: ('file', 'native')).

Screenshot 2022-12-12 at 2 28 24 AM

To reproduce:

  1. convert minimal.txt to minimal.lua
  2. nvim -u minimal.lua
  3. try ./ in insert mode (inline autosuggestion should appear)
  4. do <S-Tab> to open manual completion
  5. Scroll items

Problem disappear when completeopt does not contain noselect or noinsert.

minimal.txt

Shougo commented 1 year ago

Reproduced... Hm

Shougo commented 1 year ago

Fixed.

phgz commented 1 year ago

Since commit 4b23ca7 on Shougo/ddc.vim, this glitch is back.

For manual complete, I'm using ddc#map#manual_complete(#{ sources: ['file'], ui: 'native'}).

Screenshot 2023-01-21 at 5 18 07 PM

For the reproduction, it is the same as the original, apart from the ddc#map#manual_complete call which is now with the new interface.

Is it due to the removal of this line await ddc.autoload(denops, "ui", [options.ui]); in denops/ddc/app.ts file?

Shougo commented 1 year ago

Fixed. Please update ddc.vim.

Is it due to the removal of this line await ddc.autoload(denops, "ui", [options.ui]); in denops/ddc/app.ts file?

No.

phgz commented 1 year ago

Thanks! It is now working as intended :)