Shougo / ddc.vim

Dark deno-powered completion framework for Vim/Neovim
MIT License
676 stars 32 forks source link

Typing keys quickly may not open the popup correctly. #108

Closed orokasan closed 2 years ago

orokasan commented 2 years ago

Warning: I will close the issue without the minimal init.vim and the reproduction instructions.

Problems summary

Typing keys quickly may not open the ddc completion window correctly. It seems to be reproduced when there are many candidates. I'm using skkeleton here for reproduction, but I think it's a problem that can occur with other sources. Thanks.

Expected

Even if you type the key quickly, popups open correctly.

Environment Information

Provide a minimal init.vim/vimrc without plugin managers (Required!)

let s:plugins = [
      \ 'vim-denops/denops.vim',
      \ 'Shougo/ddc.vim',
      \ 'Shougo/ddc-ui-native',
      \ 'Shougo/ddc-matcher_head',
      \ 'Shougo/ddc-sorter_rank',
      \ 'Shougo/ddc-around',
      \ 'kuuote/denops-skkeleton.vim',
      \ ]

for item in s:plugins
  execute 'set runtimepath+=~/.cache/dein/repos/github.com/' . item
endfor

call ddc#custom#patch_global('sourceOptions', {
\ 'skkeleton': {'mark': 'skk', 'matchers': ['skkeleton'], 'sorters': [], 'isVolatile': v:true},
\ })
call ddc#custom#patch_global({'ui': 'native'})
call ddc#custom#patch_global('sources', ['skkeleton'])

call skkeleton#config({'globalJisyo': expand('~/.skk/SKK-JISYO.L')})

imap <C-j> <Plug>(skkeleton-toggle)

call ddc#enable()

How to reproduce the problem from neovim/Vim startup (Required!)

  1. Open neovim and enter insert mode.
  2. to enable skkelton
  3. input 'kou' and popup open
  4. If inputting 'ho' insanely quick, popup doesn't open.

Screenshot (if possible)

https://user-images.githubusercontent.com/47175337/199009018-f1918188-fea5-4c7e-8b23-317ca5aa9b98.mov

Shougo commented 2 years ago

The cancel is reproduced. But it is ddc problem? Really? I will check it later.

Shougo commented 2 years ago

Oh, it is ddc's lock/skip feature. But it is required to completion lockup.

Shougo commented 2 years ago

I have removed the feature.

orokasan commented 2 years ago

Thanks for the quick fix!