Shougo / ddu-ui-ff

Fuzzy finder UI for ddu.vim
MIT License
55 stars 26 forks source link

When getPreviewer returns TerminalPreviewer, previewContentsTerminal raises error #101

Closed kyoh86 closed 1 year ago

kyoh86 commented 1 year ago

Problems summary

Title says it all.

Expected

No error

Environment Information

NVIM v0.10.0-dev-3bf887f
Build type: Release
LuaJIT 2.1.0-beta3

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/share/nvim"

Run :checkhealth for more info

Provide a minimal init.vim/vimrc without plugin managers (Required!)

" Your minimal init.vim/vimrc
let g:denops#deno = "~/path/to/deno"
set runtimepath+=~/path/to/denops.vim
set runtimepath+=~/path/to/ddu.vim
set runtimepath+=~/path/to/ddu-ui-ff
set runtimepath+=~/path/to/ddu-source-git

function! DduSourceGit()
  cd ~/path/to/ddu.vim
  call ddu#start(#{
        \   sources: [#{name: "git_log"}],
        \   ui: "ff",
        \   uiParams: #{
        \     ff: #{
        \       autoAction: #{ name: "preview" }
        \     }
        \   },
        \ })
endfunction

How to reproduce the problem from neovim/Vim startup (Required!)

  1. :call DduSourceGit()

Screenshot (if possible)

Upload the log messages by :redir and :message (if errored)

Error detected while processing function <lambda>59[1]..<SNR>166_do_auto_action[12]..ddu#ui#sync_action[1]..ddu#ui_sync_action[4]..ddu#_request[15]..denops#request[1]..denops#server#request[4]..denops#_internal#server#chan#request[4]..denops#_internal#rpc#nvim#request:
line    1:
Error invoking 'invoke' on channel 4:
0,Vim:E119: Not enough arguments for function: ddu#ui#ff#_open_preview_window
Shougo commented 1 year ago

Fixed.

kyoh86 commented 1 year ago

@Shougo it is not fixed is it?

Shougo commented 1 year ago

It is already fixed.

Please see https://github.com/Shougo/ddu-ui-ff/commit/e9c8b22d3e04599e059c5d5b0c073037e9abe254.