Shougo / ddu-ui-ff

Fuzzy finder UI for ddu.vim
MIT License
55 stars 26 forks source link

Filter window cannot fixed. #46

Closed nekowasabi closed 2 years ago

nekowasabi commented 2 years ago

Problems summary

When using ddu-ui-ff to display a filter window, the window division is not fixed and the window width changes repeatedly.

Expected

Filter windows is fixed.

Environment Information

Provide a minimal init.vim/vimrc with less than 50 lines (Required!)

if &compatible
  set nocompatible               " Be iMproved
endif

if empty(glob('/path/to/vim/autoload/plug.vim'))
  silent !curl -fLo ~/.vim/autoload/plug.vim --create-dirs
        \ https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
  autocmd VimEnter * PlugInstall | source $MYVIMRC
endif

call plug#begin('/path/to/vim/plugged')
Plug 'vim-denops/denops.vim'
Plug 'Shougo/ddu.vim'
Plug 'Shougo/ddu-ui-ff'
Plug 'Shougo/ddu-filter-matcher_substring'
Plug 'Shougo/ddu-kind-file'
Plug 'Shougo/ddu-ui-filer'
Plug 'Shougo/ddu-commands.vim'
call plug#end()

 " ddu
 " Specify matcher.
 call ddu#custom#patch_global({
    \   'ui': 'ff',
    \   'sourceOptions' : {
    \     '_' : {
    \       'ignoreCase': v:true,
    \     },
    \   },
    \ })

nnoremap <silent> <space><space> <Cmd>Ddu
   \ -name=search mr -ui-param-startFilter=v:true<CR>

How to reproduce the problem from neovim/Vim startup (Required!)

  1. Add minimal vimrc settings to your vimrc.
  2. Close Gvim.
  3. Boot Gvim.
  4. Wait denops process (ex. about 10 sec)
  5. Key type to execute Ddu mr
  6. Displayed filter window process, but filter windows height is not fixed.

Screenshot (if possible)

ddu

Shougo commented 2 years ago

Please fix the reproduce instruction.

And your screenshot is not same with minimal vimrc. It is confusing for me.

Shougo commented 2 years ago

It works for me.

set rtp+=~/work/denops.vim
set rtp+=~/work/ddu.vim
set rtp+=~/work/ddu-commands.vim
set rtp+=~/work/ddu-ui-ff
set rtp+=~/work/ddu-kind-file
set rtp+=~/work/ddu-filter-matcher_substring
set rtp+=~/work/ddu-source-file

call ddu#custom#patch_global({
      \   'ui': 'ff',
      \   'sourceOptions' : {
      \     '_' : {
      \       'ignoreCase': v:true,
      \     }
      \   },
      \ })

nnoremap <silent> <space><space> <Cmd>Ddu
      \ -name=search file -ui-param-startFilter=v:true<CR>
Shougo commented 2 years ago

I have tested it agein by nnoremap <silent> <space><space> <Cmd>Ddu \ -name=search file -ui-param-startFilter=v:true<CR>. But I cannot reproduce it.

Shougo commented 2 years ago

This minimal vimrc is better:

set rtp+=~/work/denops.vim
set rtp+=~/work/ddu.vim
set rtp+=~/work/ddu-commands.vim
set rtp+=~/work/ddu-ui-ff

call ddu#custom#patch_global({
      \   'ui': 'ff',
      \ })

nnoremap <silent> <space><space> <Cmd>Ddu
      \ -name=search mr -ui-param-startFilter=v:true<CR>
Shougo commented 2 years ago
GVim 8.2
patch 1-3438

It seems old. Please use nightly build instead.

Shougo commented 2 years ago

Environment Information

ddu-ui-ff is the latest? And please check ddu-ui-ff window is winfixheight.

Shougo commented 2 years ago

@nekowasabi Please test it on the other environments. In neovim and Linux.

Shougo commented 2 years ago

OK. I get it. If winfixheight is not set, the problem is reproduced. So your ddu-ui-ff is old.

nekowasabi commented 2 years ago

@Shougo Update to nightly Gvim and update ddu-ui-ff. So, it worked.

Thank you!!