Shougo / ddu-ui-ff

Fuzzy finder UI for ddu.vim
MIT License
55 stars 26 forks source link

split param is not work when filer is open #75

Closed kamecha closed 1 year ago

kamecha commented 1 year ago

Warning: I will close the issue without the minimal init.vim and the reproduction instructions.

Problems summary

When I use ddu-ui-ff and ddu-ui-filer with different split params, these settings is not work. For example, when I use ddu-ui-ff with split: floating and ddu-ui-filer with split:vertical ...

Expected

Environment Information

set rtp+=path/vim-denops/denops.vim
set rtp+=path/Shougo/ddu.vim
set rtp+=path/Shougo/ddu-ui-ff
set rtp+=path/Shougo/ddu-ui-filer
set rtp+=path/Shougo/ddu-source-file
set rtp+=path/Shougo/ddu-source-file_rec
let s:ddu_config_json =<< trim MARK
    {
        "uiParams": {
            "ff": {
                "split": "floating"
            },
            "filer": {
                "split": "vertical"
            }
        }
    }
MARK

let s:ddu_config_json = s:ddu_config_json->join('')->json_decode()

call ddu#custom#patch_global(s:ddu_config_json)

nnoremap [ddu] <Nop>
nmap <Space>u [ddu]
nmap <silent> [ddu]f <Cmd>call ddu#start({
            \ 'ui': 'ff',
            \ 'sources': [{'name': 'file_rec', 'params': {}}],
            \ })<CR>
nmap <silent> [ddu]e <Cmd>call ddu#start({
            \ 'ui': 'filer',
            \ 'sources': [{'name': 'file', 'params': {}}],
            \ })<CR>

How to reproduce the problem from neovim/Vim startup (Required!)

Screenshot (if possible)

ff filer
image image
filer ff
image image

Upload the log messages by :redir and :message (if errored)

Shougo commented 1 year ago

Sorry. it(dynamic UI change) is not supported behavior.

kamecha commented 1 year ago

Oh... 😭 But I understand the behavior is actually a part of the plugin's intended functionality. Thank you for letting me know. 👍

Shougo commented 1 year ago

I have implemented the feature. Please update ddu.vim.

kamecha commented 1 year ago

Thanks for adding the requested feature!