Shougo / dein.vim

:zap: Dark powered Vim/Neovim plugin manager
MIT License
3.42k stars 197 forks source link

fix: bashism #483

Closed e-kwsm closed 1 year ago

e-kwsm commented 1 year ago

The shebang of bin/installer.sh is #!/bin/sh but it is not POSIX-compatible:

The simplest solution, I believe, is to use bash.

samyilin commented 1 year ago

No need to revert to Bash. We don't really need ➤ as a prompt, no need to revert to Bash because of this. &> can be replaced with >>/dev/null 2>&1, longer but is POSIX compliant, far as I know (Busybox ash does not complain, shellcheck didn't complain either). See Bash Pitfalls

Shougo commented 1 year ago

485 is better and it is merged.