Hi. Thanks for developing dein.vim. No dein.vim, no my Vim life.
I have an issue that the "Done" message, e.g., "Done: (2023/01/02 03:04:05)", of dein#check_update() is ignored if there are no updated plugins. This issue is caused as follows:
This pull request fixes the issue. Even if context is empty, s:notify() will call s:updates_log() and assign s:progress. Then only if context isn't empty, s:notify() will check context.message_type and call dein#util#_notify().
Hi. Thanks for developing dein.vim. No dein.vim, no my Vim life.
I have an issue that the "Done" message, e.g., "Done: (2023/01/02 03:04:05)", of
dein#check_update()
is ignored if there are no updated plugins. This issue is caused as follows:dein#check_update()
callsdein#install#_check_update()
internallydein#install#_check_update()
callsdein#install#_get_updated_plugins()
and checks if there are updated pluginss:notify()
for sending the "Done" message and finishes its update processcontext
is empty,s:notify()
does nothing and the "Done" message is ignoredcontext
is derived froms:global_context
, that is empty becausedein#install#_get_updated_plugins()
makes it emptyThis pull request fixes the issue. Even if
context
is empty,s:notify()
will calls:updates_log()
and assigns:progress
. Then only ifcontext
isn't empty,s:notify()
will checkcontext.message_type
and calldein#util#_notify()
.