Closed lambdalisue closed 8 years ago
I don't want to depend on vim-rplugin. But I can include vim-rplugin into denite.nvim.
Ok. Fair enough. vim-rplugin is MIT so you can copy if you like the way :-)
In case while I forgot to mention, vim-rplugin is only required for people who want to use the plugin in vim8 and neovim user never need that.
That why I decide to rely on that plugin for further my products while I decide to use rplugin strategy for main and vim8 support is now optional feature for me.
In case if you mis-understood and thought the vim-rplugin dependency exist also for neovim users.
I have included rplugin into denite.nvim. It seems better. Thanks.
Problems summary
Currently denite.vim support Vim 8 by extending
vim
module directly butvim
is shared to all plugins so once your approach got famous, there would be tons of variation ofvim.call()
implementations and each other will be conflictvim.vars
,vim.options
or whatever returnsbytes
instead ofstr
in Python 3 and it would cause Unicode encode/decode errorRFC
Recently I made vim-rplugin to solve all problems above. So what do you think about relying on that plugin to support Vim 8? If you are OK with this idea, I will implement the feature sometime ;-)
Pros.
vim
module rather than extend so thatvim.call()
always returns what you want.bytes
tostr
so you don't have to change codes for Neovim and Vim 8Cons.