broken on dbus nodejs 13

[p3x-robot]

https://travis-ci.com/patrikx3/systemd-manager/builds/133191750?utm_medium=notification&utm_source=email

[p3x-robot]

> dbus@1.0.5 install /home/travis/build/patrikx3/systemd-manager/node_modules/dbus
> npm run build:release
npm WARN npm npm does not support Node.js v13.0.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11, 12.
npm WARN npm You can find the latest version at https://nodejs.org/
> dbus@1.0.5 build:release /home/travis/build/patrikx3/systemd-manager/node_modules/dbus
> node-gyp configure build
make: Entering directory '/home/travis/build/patrikx3/systemd-manager/node_modules/dbus/build'
  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmlparse.o
../deps/libexpat/lib/xmlparse.c: In function ‘gather_time_entropy’:
../deps/libexpat/lib/xmlparse.c:709:7: warning: variable ‘gettimeofday_res’ set but not used [-Wunused-but-set-variable]
   int gettimeofday_res;
       ^
  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmltok.o
  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmlrole.o
  AR(target) Release/obj.target/deps/libexpat/libexpat.a
  COPY Release/libexpat.a
  CXX(target) Release/obj.target/dbus/src/dbus.o
  CXX(target) Release/obj.target/dbus/src/connection.o
  CXX(target) Release/obj.target/dbus/src/signal.o
../src/signal.cc: In function ‘void Signal::DispatchSignal(v8::Local<v8::Value>*)’:
../src/signal.cc:29:25: warning: ‘v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)’ is deprecated (declared at ../../nan/nan.h:1024) [-Wdeprecated-declarations]
                     info);
                         ^
../src/signal.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE Signal::EmitSignal(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/signal.cc:104:40: error: no matching function for call to ‘v8::Array::Get(unsigned int&)’
     Local<Value> arg = arguments->Get(i);
                                        ^
../src/signal.cc:104:40: note: candidates are:
In file included from /home/travis/.cache/node-gyp/13.0.1/include/node/node.h:63:0,
                 from ../../nan/nan.h:54,
                 from ../src/signal.cc:2:
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3463:43: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                           ^
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3463:43: note:   candidate expects 2 arguments, 1 provided
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3466:43: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                           ^
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3466:43: note:   candidate expects 2 arguments, 1 provided
../src/signal.cc:109:26: error: no matching function for call to ‘v8::Array::Get(unsigned int&)’
         signatures->Get(i)->
                          ^
../src/signal.cc:109:26: note: candidates are:
In file included from /home/travis/.cache/node-gyp/13.0.1/include/node/node.h:63:0,
                 from ../../nan/nan.h:54,
                 from ../src/signal.cc:2:
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3463:43: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                           ^
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3463:43: note:   candidate expects 2 arguments, 1 provided
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3466:43: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                           ^
/home/travis/.cache/node-gyp/13.0.1/include/node/v8.h:3466:43: note:   candidate expects 2 arguments, 1 provided
dbus.target.mk:130: recipe for target 'Release/obj.target/dbus/src/signal.o' failed
make: *** [Release/obj.target/dbus/src/signal.o] Error 1
make: Leaving directory '/home/travis/build/patrikx3/systemd-manager/node_modules/dbus/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/travis/.nvm/versions/node/v13.0.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 4.15.0-1028-gcp
gyp ERR! command "/home/travis/.nvm/versions/node/v13.0.1/bin/node" "/home/travis/.nvm/versions/node/v13.0.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "build"
gyp ERR! cwd /home/travis/build/patrikx3/systemd-manager/node_modules/dbus
gyp ERR! node -v v13.0.1
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok 
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! dbus@1.0.5 build:release: `node-gyp configure build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the dbus@1.0.5 build:release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2019-10-23T12_53_01_347Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! dbus@1.0.5 install: `npm run build:release`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the dbus@1.0.5 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2019-10-23T12_53_01_783Z-debug.log

I think it is at signatures->Get(i)

[grapereader]

I wonder if this is related?

https://github.com/nodejs/nan/issues/849

[Shouqun]

https://github.com/Shouqun/node-dbus/pull/214 fixed the build broken. However, there are still some test failures.

[p3x-robot]

so is it released that works with node 13 or not? thanks!

[p3x-robot]

ok it works, thanks!