search

Shovinus / ChopDownUpdated

Realistic Minecraft Tree Chopping
Other
6 stars 3 forks source link

A config to enable the mod for player only #10

Closed guillaumearm closed 6 years ago

guillaumearm commented 6 years ago

It could be very convenient to add a configuration field to enable the mod only when a player chop a tree (not a machine for example)

That would make automations with other mods easier. (e.g. Plant gatherer from industrial foregoing)

Shovinus commented 6 years ago

I was sure I had already fixed that because I discovered the problem before, you on the latest version?

On 21 May 2018 17:41, Guillaume ARM notifications@github.com wrote:

It could be very convenient to add a configuration field to enable the mod only when a player chop a tree (not a machine for example)

That would make automations with other mods easier. (e.g. Plant gatherer from industrial foregoing)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Shovinus/ChopDownUpdated/issues/10, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOYvhbJTzGDc6OxjKcc9nfK3rnXRwLFHks5t0u5QgaJpZM4UHR9C.

guillaumearm commented 6 years ago

Yes I'm using ChopDownUpdater v1.0.9 for minecraft 1.12.2+

I'm using Industrial Foregoing v1.9.0-163 (minecraft 1.12.2 too)

Shovinus commented 6 years ago

I will look again, I thought I had solved by making it so if the player position was 0,0,0 then don't do the chop because most fake players don't set this and so it defaults to 0,0,0. The issue I had was getting foregoing to work in dev environment.

On 21 May 2018 18:17, Guillaume ARM notifications@github.com wrote:

Yes I'm using ChopDownUpdater v1.0.9 for minecraft 1.12.2+

I'm using Industrial Foregoing v1.9.0-163 (minecraft 1.12.2 too)

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Shovinus/ChopDownUpdated/issues/10#issuecomment-390721211, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOYvheXO5kKN6NL2pyBJh2Q7lX1JgqNWks5t0va2gaJpZM4UHR9C.

guillaumearm commented 6 years ago

Hmmm, are you sure industrial foregoing use fake players for doing that kind of things ?

Shovinus commented 6 years ago

Not 100% but my code relies on a given player as it uses the player to a) calculate the drop direction, and b) determine debug effects like makeGlass which are only usable by admin. So if no player is passed I would have expected an error tbh.

On 21 May 2018 18:52, Guillaume ARM notifications@github.com wrote:

Hmmm, are you sure industrial foregoing use fake players for doing that kind of things ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Shovinus/ChopDownUpdated/issues/10#issuecomment-390731066, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOYvhT-G7WQJQZuM6KPC6KJEE09S3mzHks5t0v7WgaJpZM4UHR9C.

Shovinus commented 6 years ago

691ab0d9fd59bf9c96a0423dc80dbc148c7ed412 Fixes (though forgot to put in commit message)