Displays Char+Player name incorrectly when using Illandril's Chat Enhancements 2.0

[dstein766]

FVTT 10.287 DND5E 2.0.3 Chat Portraits 0.8.8 Illandril's Chat Enhancements 2.0

Illandril's automatically displays the speaker on chat cards in the format "CharacterName [PlayerName]" With Chat Portrait enabled, cards display in format "CharacterNamePlayerName" (so not only are the square brackets lost, but so is the space between names).

Happens regardless of Chat Portrait's setting for "Show the names of the player next to the name of the actor". (If Illandril's is turned off and CP's setting is turned on, works as expected...although [CharacterName] [PlayerName] renders BELOW the portrait rather than to the right of the portraits as when Illandril's is enabled.)

FWIW: the main reason I use Illandril's is for its feature of displaying the name of the token you are currently controlling just above the chat input area. Helpful for a DM to avoid accidentally speaking as the wrong token. I actually don't care about the "CharacterName [PlayerName]" display and would turn it off if I could, but it happens to come along for the ride when using Illandril's. If Chat Portrait happened to offer the "show name of token you are controlling" feature I'd dump Illandril's entirely.

[p4535992]

Sorry i didn't get the request, can you made a screenshot of the result you would like ?

[dstein766]

Thanks for looking into this!

The attached images show the output when a) ONLY Illandril's Chat Enh active (looks fine) b) ONLY Chat Portrait (with the option to display player names turned off) active (looks fine...also looks OK if I turn on the option to display player name, too) c) BOTH active (character name and player name incorrectly mashed together as a single label)

In the case when BOTH are active, the CP setting related to whether to show the player's name alongside the character name is irrelevant. The display is as shown in either case. (In the specific example I provided, the option to show player name is OFF in CP settings.)

My best-guess is that Illandril's is called earlier and passes "CharName [PlayerName]" to CP, which is interpreting that whole string as just the character name and then removing the space and square brackets before rendering that as the character name...but ONLY a guess.

(Hopeful that attaching files to my reply gets these into the bug report correctly.)

------ Original Message ------ From "4535992" @.> To "ShoyuVanilla/FoundryVTT-Chat-Portrait" @.> Cc "dstein766" @.>; "Author" @.> Date 10/12/2022 7:15:34 AM Subject Re: [ShoyuVanilla/FoundryVTT-Chat-Portrait] Displays Char+Player name incorrectly when using Illandril's Chat Enhancements 2.0 (Issue

120)

Sorry i didn't get the request, can you made a screenshot of the result you would like ?

— Reply to this email directly, view it on GitHub https://github.com/ShoyuVanilla/FoundryVTT-Chat-Portrait/issues/120#issuecomment-1276254242, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6JSZ5MUTEXPQK7DPOYQYTWC3BYNANCNFSM6AAAAAARA3ZE3Y. You are receiving this because you authored the thread.Message ID: @.***>

[p4535992]

For attach images use github or i can't see the attachment. Try out 0.8.10 i have tried to fix the issue.

[dstein766]

When ONLY Illandril's Chat Enhancements active:

When ONLY Chat Portraits active:

When BOTH active: Note how the character name (Evrostos) has been joined to the player name (Martin) to create a mal-formed name.

[dstein766]

CONFIRMED FIXED in 0.8.10 - thanks!