ShoyuVanilla / FoundryVTT-Chat-Portrait

Other
14 stars 24 forks source link

"Display Chat Flavor Text Next to Portrait #19

Closed Mr-Monocyte closed 3 years ago

Mr-Monocyte commented 4 years ago

I don't think I'm getting the correct display when I select this.

Attached is an image of what I get when I check that box. This is with no other modules installed and only Foundry 0.6.6 and the latest version of the Pathfinder 2e system.

Aren't I supposed to be seeing the "Perception Check" and the blue bonus summary boxes to the right of the character portrait?

2020-10-06 (1)

SepSepone commented 4 years ago

First things first, thx for the module ShoyuVanilla. I have a similar issue with the Chat Flavor Text. If I use a roll directly from the character sheet (Shadowrun 5e game system) it always shows the character's name. And when an item in the Hotbar is used, the item name is shown. Regardless if Chat Flavor Text option is checked or unchecked. Maybe Chat Flavor means something else? But I can't figure out what it's for... With regards, stay healthy.

esparen commented 3 years ago

I have the a similar issue with the pathfinder 2e System. It seems that the CSS for the icon is broken in the chat timeline, with the token appearing bellow the name, between the the skill check and the result. image

p4535992 commented 3 years ago

Can you check if this issue is fixed with version 0.2.6 ?

SepSepone commented 3 years ago

Thx p4535992 for continuing this mod. The portrait is shown all the time now. Albeit only as long as the option "Use Token Image" is unchecked. but I guess that's a different issue. Stay safe and enjoy yourself!

p4535992 commented 3 years ago

So can i close this issue ?

SepSepone commented 3 years ago

The only issue I see with this mod is that FoundryVTT itself already shows the character's portrait when a skill is used (or something similar that got no icon/symbol of its own), so we get the same portrait twice (above each other). As long as an item or special trait with it's own icon is used the mod is neat, showing the portrait above the item's/trait's symbol. Don't know how deep you wanna dive into this to make it "perfect". As far as the original issue goes, "portrait not shown", I'd call the problem solved.

p4535992 commented 3 years ago

Yea i leave this in the TODO list.

p4535992 commented 3 years ago

Hey SepSepone i made a "ImageReplacer" mechanism for avoid the double portrait issue . For now i supported the standard labels of Dnd5e, but let me know if for PF2 i miss something.

SepSepone commented 3 years ago

Sorry, I don't play PF2, I can only tell you that the "ImageReplacer" works fine for DnD, but doesn't work with Shadowrun 5e.

p4535992 commented 3 years ago

Yea i just noticed the html card change by the system used, i'm not sure if i will find the time to patch the other system on the short term.

SepSepone commented 3 years ago

Any mod support is appreciated, don't stress yourself. It's all about having fun ;)

p4535992 commented 3 years ago

Well i close this issue, because it's belong to the multisystem support, if you need support for a specific system just open a new issue.