ShoyuVanilla / FoundryVTT-Chat-Portrait

Other
14 stars 24 forks source link

Doing Ability Checks/Saves causes Portrait to revert to Player Token, not Actor/Character token. #52

Closed GambetTV closed 3 years ago

GambetTV commented 3 years ago

Using D&D5e, if anyone, GM or Player, roll a skill check for a token, the output to the chat makes it appear like it was the Token that rolled it, which is what it should be, so that I can keep track of who is rolling. When I do the same thing with Ability Checks or Saving Throws, it instead just puts the Player Name, and puts my player token on the display, with literally no way of telling which character token was rolling.

GambetTV commented 3 years ago

On further review this seems to be some kind of incompatibility with the Midi QOL mod. I am completely unclear on what would be causing the issue, whether it's on your end or theirs, but messing around with settings in both modules doesn't seem to fix it.

p4535992 commented 3 years ago

Should be fixed (partially) with 0.3.9

GambetTV commented 3 years ago

Unfortunately not. Attack Rolls, spells, and skill checks all work fine, but using Ability Checks/Saving Throws (as in, clicking on STR or DEX or any of the ability scores and selecting either Ability Score or Saving Throw) causes my Username to make the roll, with no indication as to which token I am rolling for.

Disabling the Midi QOL module fixes the issue completely. However, I suspect the bug is with your module, as your module had been working with Midi QOL fine until the most recent update I believe, and Midi QOL hasn't been updated for a month I think.

EDIT: Looking at it further, I suspect it might in fact be the Midi QOL module that's creating the bug. I'm not 100% sure though.

p4535992 commented 3 years ago

Its seem the version 0.8.31 of Midi solve the issue, give me confirmation

GambetTV commented 3 years ago

Yep! It works now, thanks!