ShoyuVanilla / FoundryVTT-Chat-Portrait

Other
14 stars 24 forks source link

Missing portraits + conflict with Monk's Token Bar #60

Closed grankless closed 3 years ago

grankless commented 3 years ago

https://i.imgur.com/eCxpgtT.png

Pictured is what happens when I have Chat Portraits enabled and attempt to award XP using Token Bar. You can see that there are these big-ass mystery icons next to people in the menu for it. I have made an issue for it https://github.com/ironmonk88/monks-tokenbar/issues/120 here.

However, since updating to Chat Portrait 4.0, all portraits have become that mystery book icon. This is kind of unusable. CP is the only module I use that interacts with portraits in any way.

JackaldaJester commented 3 years ago

Also having this issue after updating to 4.0. I don't have Monk's Token Bar enabled so don't know if there was a sudden conflict with something else.

p4535992 commented 3 years ago

Also having this issue after updating to 4.0. I don't have Monk's Token Bar enabled so don't know if there was a sudden conflict with something else.

More info please !! Always on PF2 System ?

p4535992 commented 3 years ago

For a temporary solution just disable the "Image Replacer feature", or disable the styling for chat message of type 'OTHER'

JackaldaJester commented 3 years ago

Foundry VTT Version: .8.8 Operating System: Windows 10 How Are You Using Foundry: Forge Hosting Which Game System: dnd 5e Modules Enabled?: Yes - Multiple enabled (CUB, Midi QoL, etc).

I'm also having the issue where everyone's icons, players and NPCs included, are replaced by the blue book with the question mark on it. I think that's the default image for unknown items? For now I've rolled the module back to 0.3.12 which brings everything back to normal.

p4535992 commented 3 years ago

Should be all fixed on 0.4.1 version

grankless commented 3 years ago

All that stuff works great now, however it seems something changed with the styling on the PF2e chat cards -

https://i.imgur.com/9gP9ENS.png

Previously, with Chat Portraits on - and this is the default behavior of the system - the modifiers would be under the name of the skill check. Like so:

https://i.imgur.com/Aco5VN7.png

Is there a way to tweak this, too? This is with Image Replacer off - I think it's still trying to style the text to fit the image even with that off?

p4535992 commented 3 years ago

Ok we are faced with a problem of choices in terms of style, by default I have verified (but it is purely my opinion), that the choice of "flex" at the text level is more consistent with most systems. In fact, for PF2 I prefer the first version while you instead the second, but the module still allows you to customize the text model according to your needs in this case you just need to set the "display: block" to restore the default style of PF2 as shown in the figure.

img

JackaldaJester commented 3 years ago

Everything working proper, thank you for your work!