ShoyuVanilla / FoundryVTT-Chat-Portrait

Other
14 stars 24 forks source link

[BUG] Configuration menu not appearing for players #89

Closed Silveressa closed 2 years ago

Silveressa commented 2 years ago

Module Version: v0.5.33

Describe the bug The menu to configure the module is not available for players.

To Reproduce Steps to reproduce the behavior:

  1. Log in as a player
  2. Go to "configure settings/Module Settings"
  3. The Chat Portrait configuration menu does not appear.

Expected behavior The configuration menu the GM sees should appear for the players so they can configure the appearance of the portrait window as desired.

Foundry Version: Version 9 build 272

p4535992 commented 2 years ago

Is not a bug, is a wanted thing, to much bad feedback in the past. What properties would you like players to see?

Silveressa commented 2 years ago

I was hoping for players to have the ability to resize the portraits to their liking, since currently I see this perfectly sized image for the players portrait: Char swap

But to my player the portrait looks like this with the upper top of the image cut off:

Char swap

p4535992 commented 2 years ago

Now that is strange . The css should be manage that. What browser are the player using ? is it an online world that I can access temporarily?

Silveressa commented 2 years ago

They're using Vivaldi, which apparently is what's causing the issue, after having them test it in other browsers they found it renders just fine in Firefox and Chrome. (And they're fine with using Firefox to connect to game sessions)

So not a huge issue any longer tbh.

Though regarding the original request, letting each of my players be able to scale the portrait size to their liking would be ideal, given one of my other players has vision issues and prefers scaling fonts and thumbnails larger than usual so they can make them out easily, so a way for them to do that would be ideal, but if it's not feasible I completely understand.

KeptheKobold commented 2 years ago

Adding onto this, my players are having problems where after i disable OOC portraits they still see them

p4535992 commented 2 years ago

Form version 0.7.0 , many settings are now scoped to 'client' instead of 'world', i'll close this issue.