search

Shpoike / Quakespasm

Extra bloaty junk to modernise stuff a bit.
http://triptohell.info/moodles/qss/
GNU General Public License v2.0
184 stars 41 forks source link

really fix lightmap issues #67

Closed sezero closed 2 years ago

sezero commented 2 years ago

As noted at https://github.com/Shpoike/Quakespasm/commit/5cbb199b5cf5aece009be92c0a9b8bacf33c7546#comments, lightmaps are still broken (see attached screenshot.) Fix picked from https://github.com/sezero/quakespasm/commit/94db75126c4891c36a9e373f312a795cc9847f1f

e2m1

adelpha commented 2 years ago

Does this also fix the issue with entities appearing black in certain places in DoTM? Video below:

https://youtu.be/lrmQSEon24k

sezero commented 2 years ago

Does this also fix the issue with entities appearing black in certain places in DoTM?

Honestly don't know - and won't try it myself.

garoto commented 2 years ago

Does this also fix the issue with entities appearing black in certain places in DoTM? Video below:

Applied sezero's patch ontop of the qsrebase branch and nope:

spasm0001

adelpha commented 2 years ago

I'll open a new issue for this, rather than cluttering this perfectly good PR any more.

sezero commented 2 years ago

Looks like this has been fixed by merging mainstream changes.