ShrRa / python-intermediate-development

Intermediate Python for Astronomical Software Development
https://shrra.github.io/python-intermediate-development/
Other
3 stars 4 forks source link

Add context for new function example #14

Closed rachel3834 closed 4 days ago

rachel3834 commented 5 days ago

In the Setting the Scene section of the Issue Diagnostics chapter, the instructions would benefit from clarifying whether the new function should be added to an existing file or as a new file and if so, in what part of the directory structure.

RileyWClarke commented 4 days ago

I believe the intent is for the new function to be added to light-curve-analysis.ipynb, since there is an optional exercise later to move it to lcanalyzer/models.py and add an associated test in tests/test_models.py. Context added in 37ce4276e1942c635801ef3519c007443082535f.