search

Shrediquette / PIVlab

Particle Image Velocimetry for Matlab, official repository
https://shrediquette.github.io/PIVlab/
MIT License
126 stars 30 forks source link

PIVlab_commandline issues #14

Closed quynhneo closed 3 years ago

quynhneo commented 3 years ago

https://github.com/Shrediquette/PIVlab/blob/main/PIVlab_commandline.m is not ready to run, for example https://github.com/Shrediquette/PIVlab/blob/main/PIVlab_commandline.m#L16 has s=cell(11,2) but should be s=cell(13,2) since version 2.01 , or it doesn't save the results, etc. Anyway I have modified the script to make it standalone program, with parallel processing options (which was critical because I had a TB of images to process). If pull requests are welcome, I will submit one.

Shrediquette commented 3 years ago

Hi, this shouldn't cause a real issue, because the cell array will be resized when new elements are assigned. But I agree that it is bad coding and should be fixed. I am happy to receive pull requests. But do I need the parallel processing toolbox for it to work? I don't have it, so I can't check the functionality.

quynhneo commented 3 years ago

yes, it looks like there is a free trail version https://www.mathworks.com/products/parallel-computing.html

Shrediquette commented 3 years ago

But then I can only test it once and if it is broken with a change in some function, I can never test it again :( There is no solution without an additional toolbox?

quynhneo commented 3 years ago

Not that I know of... This sucks, your software is making matlab better and more popular but they are not making it easy for you. Is there no special privilege that comes with being a popular contributor? Can you ask them for a free license?

Shrediquette commented 3 years ago

Hi, no they will not help me. Once, I was asking for an extension of the trial period, because mathworks implemented a huge change that broke pivlab completely. As far as I remember, my request was ignored. I would like to keep the required toolboxes at minimum in PIVlab. The image processing toolbox bis ok in my point of view, because I guess 98% of all MATLAB installations will also have this toolbox.

quynhneo commented 3 years ago

parallel processing could be made optional, and put in a try catch block, so no one without the toolbox would accidentally run it.