ShrimpCryptid / Secret-Hitler-Online

An online version of Secret Hitler, a social deduction board game.
71 stars 13 forks source link

Player roles are shown too early during victory sequence (or not shown at all). #140

Open ShrimpCryptid opened 2 months ago

ShrimpCryptid commented 2 months ago

Moved from #132.

The roles of all players are shown too early during the final action (execution/policy/chancellor voting) instead of only during the final victory screen.

Also, on testing with multiple windows at the same time, I found that one (Liberal) player was not shown the roles of other players at the end of the game at all.

Reproduction:

  1. Open five windows/tabs with the dev build: https://secret-hitler-online-dev0.web.app/
  2. Create a lobby and join it with all five users.
  3. Click through the game and reach any of the victory states.
  4. During the final action, the player roles will be visible.

Notes

Could be solved by adding conditional in PlayerDisplay.tsx so it only shows roles that the player should know about, unless a flag is set that enables all player roles to be seen at the victory stage?