Shruthi0310 / pe

0 stars 0 forks source link

Able to edit JSON file and add venue to an appointment that is not scheduled yet #7

Open Shruthi0310 opened 2 years ago

Shruthi0310 commented 2 years ago

Steps to reproduce: Edit the JSON file of a person with no appointment scheduled and change their venue.

Expected outcome: Error to be shown that the venue will be removed since there is no appointment scheduled

Actual outcome: Shows a client with appointment that has venue but no scheduled appointment

image.png

The same applies when time, etc, is added without an appointment in the first place.

nus-pe-bot commented 2 years ago

Team's Response

This problem can only happen in case of deliberate sabotage, it does not make sense to add in a venue without an appointment.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is is not a deliberate sabotage as it is possible for users to attempt to modify the JSON data directly and it is possible that they accidentally add details like the venue, time, etc to an appointment that has not been scheduled yet. Hence I feel that this should be handled when loading the data and give a warning, otherwise this would result in more trouble for the users when they can't remove the accidentally added details using the commands since it would give the error that the appointment doesn't exist. So I think that this bug should be accepted.