search

Shruthi0310 / pe

0 stars 0 forks source link

Wrong use of inheritance #8

Open Shruthi0310 opened 2 years ago

Shruthi0310 commented 2 years ago

In the following diagram, LogicManager inherits the FastParser, but there seems to be no such association (i.e no inheritance between the two classes)

image.png

nus-pe-bot commented 2 years ago

Team's Response

This is an typo issue in the puml file. Our diagram below shows that its a dependency instead of inheritance.

image.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I do not think that this should of very low severity because a typo is something that the readers would catch easily and should not affect their understanding, but in this case, the readers would not see the puml file to look for the error and hence I would not consider this merely a typo. When looking at the two images, they might be confused as to why one of the diagrams shows inheritance while the other shows dependency. I would classify this a medium severity because it causes inconvenience to the readers to find out how the mentioned classes are associated by looking through the code, etc.