search

Shubhamjain007 / openhab

Automatically exported from code.google.com/p/openhab
0 stars 0 forks source link

Enhance SNMP-Binding (Out-Binding) #107

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
1. Feature Description
It would be great if openhab could poll values via snmp from other devices.
Instead of getting snmp-traps.

2. Example Use Case
Gettings temperature values from an OW-SERVER-ENET via SNMP 
(http://www.embeddeddatasystems.com/OW-SERVER-1-Wire-to-Ethernet-Server-Revision
-2_p_152.html)

Or reading values for cpu_load, hdd_temp, free_ram, ... from a server.

Original issue reported on code.google.com by christop...@gmail.com on 23 Aug 2012 at 1:38

GoogleCodeExporter commented 8 years ago 
Personally, I think it should replace the existing version, and a note made to 
existing users that they need to change their binding strings when they 
upgrade. I think having a second binding that's almost the same as the old one 
is a bit silly - but that's just my opinion.

However, I would like to get someone with the old binding to upgrade to see if 
it still does the same thing the old one did. The old binding only received 
traps - we've tested this and it works, but it would be nice to make sure it's 
compatible (it should be, but...).

I'm not sure if this is going into 1.3 - I have notified that this change has 
been made, but I don't think the changes have been pulled into the main OH 
development.

Original comment by ch...@cd-jackson.com on 7 Aug 2013 at 9:45

GoogleCodeExporter commented 8 years ago

Original comment by teichsta on 13 Aug 2013 at 3:36

GoogleCodeExporter commented 8 years ago 
Chris, i merged your enhancement to the default branch. Many thanks for this 
enhancement. Please find below some review comments:

# SnmpGenericBindingProvider
* could you please add some valid configuration examples for out binding
* method parseBindingConfig() contains '// TODO: Some type conversion required 
here!?!' - Any suggestions how to proceed?
* could please add some class level javadoc for SnmpBindingConfig

# openhab_default.cfg
* could you please provide configuration examples for the new parameters 'port' 
and 'retries'

# Wiki
* could you please update the SNMP-Wiki accordingly (write permission is 
granted meanwhile)

It would be great if you could combine your changes into one changeset as this 
would be more convenient to pull ;-)

Best,

Thomas E.-E.

Original comment by teichsta on 14 Aug 2013 at 9:47

GoogleCodeExporter commented 8 years ago 
Out binding examples added
The TODO is removed - I've fixed this to only support numbers (SNMP Type 
Integer32)
Examples added to the cfg
Wiki updated

Hopefully it's all in here -:
https://code.google.com/r/chris-openhab/source/detail?r=de5f8522218a4d44a217520f
65c80c4134ce40ec

Original comment by ch...@cd-jackson.com on 15 Aug 2013 at 7:32

GoogleCodeExporter commented 8 years ago 
Updated changeset (small tidy up)-:
https://code.google.com/r/chris-openhab/source/detail?r=3ccc37c32fe1a11b4504a883
cbdef3c9a007be89

Original comment by ch...@cd-jackson.com on 15 Aug 2013 at 9:57

GoogleCodeExporter commented 8 years ago 
Thanks Chris, will merge your change sets asap.

Original comment by teichsta on 16 Aug 2013 at 6:37

GoogleCodeExporter commented 8 years ago 
Merged your changeset into default (see 
http://code.google.com/p/openhab/source/detail?r=c43d392cff7fbca7fa8e0a571e88a66
468b1a89f)

Original comment by teichsta on 16 Aug 2013 at 7:04