search

Shubhamrawat5 / apple-playlist-downloader

apple music playlist downloader (mp3) in node js
96 stars 26 forks source link

Major update - Lyrics #14

Closed b5i closed 2 years ago

b5i commented 2 years ago

Hi! This PR is a big update that ends the transition of this repository to a full-metadata script ! Includes last feature : Get time-synced lyrics of all the tracks downloaded (last time I did that I got 50% found) Don't hesitate to write time synced on Megalobiz.com that is the website where the script fetch the lyrics (and it's super easy !)

I use my code : https://github.com/antoinebollengier/lyrics_finder

Thanks for adding the hacktoberfest tag to this PR 👍

Shubhamrawat5 commented 2 years ago

I think your forked repo is behind mine.

In your repo: This branch is 21 commits ahead, 2 commits behind Shubhamrawat5:master.

Shubhamrawat5 commented 2 years ago

There are still 2 major issues. 1- SEARCHING FOR LYRICS... error: Command failed: python3 searcher.py 'Andy Grammer' 'Lease On Life' 'Andy Grammer' 'python3' is not recognized as an internal or external command, operable program or batch file.

My system has "python" not "python3" so other people may have same

2- Lyrics python file is not working stdout give "LYRICS NOT FOUND\r\n" for every song

b5i commented 2 years ago

There are still 2 major issues. 1- SEARCHING FOR LYRICS... error: Command failed: python3 searcher.py 'Andy Grammer' 'Lease On Life' 'Andy Grammer' 'python3' is not recognized as an internal or external command, operable program or batch file.

My system has "python" not "python3" so other people may have same

2- Lyrics python file is not working stdout give "LYRICS NOT FOUND\r\n" for every song

  1. is done now
Shubhamrawat5 commented 2 years ago

Pls make another fresh PR.