ShuffleBox / django-rcsfield

Automatically exported from code.google.com/p/django-rcsfield
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Wiki: Revision detail view fails on git #14

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The revision urlconf view only accepts 0-9 for revision id's. Git (and HG) uses 
hashes for ids.

diff --git a/rcs/wiki/urls.py b/rcs/wiki/urls.py
index 91a3b14..184a737 100644
--- a/rcs/wiki/urls.py
+++ b/rcs/wiki/urls.py
@@ -4,7 +4,7 @@ urlpatterns = patterns('rcs.wiki.views',
     url(r'^((?:[A-Z]+[a-z]+){2,})/$', 'page', {}, name="wiki_page"),
     url(r'^((?:[A-Z]+[a-z]+){2,})/edit/$', 'edit', {}, name="wiki_edit"),
     url(r'^((?:[A-Z]+[a-z]+){2,})/attachments/$', 'attachments', {}, name="wiki_attachments"),
-    url(r'^((?:[A-Z]+[a-z]+){2,})/rev/([0-9]+)/$', 'revision', {}, 
name="wiki_revision"),
+    url(r'^((?:[A-Z]+[a-z]+){2,})/rev/([a-f0-9]+)/$', 'revision', {}, 
name="wiki_revision"),
     url(r'^((?:[A-Z]+[a-z]+){2,})/diff/([\w]+)/([\w]+)/$', 'diff', {}, name="wiki_diff"),
     url(r'^list/$', 'list', {}, name="wiki_list"),
     url(r'^recent/$', 'recent', {}, name="wiki_recent"),

Original issue reported on code.google.com by mar...@mahner.org on 26 May 2009 at 6:13

GoogleCodeExporter commented 9 years ago

Original comment by a...@rcs4u.de on 26 May 2009 at 6:39

GoogleCodeExporter commented 9 years ago
fixed in r95. thanks Martin!

Original comment by a...@rcs4u.de on 27 May 2009 at 9:26