ShukantPal / pixi-essentials

The best goodies for performant, enterprise-level applications built on PixiJS
https://api.pixijs.io
MIT License
275 stars 36 forks source link

Do you planning to add PixiJS V8 support for Transformer package? #105

Open talhaozdemir opened 5 months ago

ShukantPal commented 5 months ago

I'm happy to review a PR. At the moment, I'm unable to work on this myself due to time constraints and managing mental health.

talhaozdemir commented 5 months ago

@ShukantPal I tried to migrate the plugin to V8 but I have some issues on some scripts, I need your help at this point.

1- decomposeTransform(displayObject.transform, tempMatrix)

displayObject doesn't have transform property, so I changed this to

decomposeTransform(
    {
      rotation: displayObject.rotation,
      skew: displayObject.skew,
      scale: displayObject.scale,
      pivot: displayObject.pivot,
      position: displayObject.position,
    } as Transform,
    tempMatrix,
  );

but in this case, it is working buggy, for example if I try to scale with handles, the object disappear when negative scaling occurs

2- I don't know why, if dev tools opened in the browser, I cannot transform object position, it is slow

I am sharing the working demo, If you can help, I would be very happy. I add comments starts with "// V8" for changed parts

transformer-test-v8.zip

ShukantPal commented 5 months ago

@talhaozdemir Can you open a draft PR? I'll take a look when I have time.

talhaozdemir commented 5 months ago

@ShukantPal thanks, I've opened a PR.