ShulkerSakura / SPBR

A renewed textures pack based on VNR
GNU General Public License v3.0
68 stars 1 forks source link

`grass_block_side.png` is not default and still doesnt have baked lighting #7

Closed andrwcrr closed 9 months ago

andrwcrr commented 9 months ago

I'm not sure if this is intentional or not because you replaced almost all albedo textures with their default except for grass_block_side.png. If this was not your intention then this is what it looks like currently in SPBR: 2023-12-12_01 23 45 And this is what it looks like in vanilla: 2023-12-12_01 23 36 As you can see SPBR is missing some shading under the grass part of the block.

P.S. If you want the pack to have unedited vanilla textures then you can just remove all the vanilla textures from your resource pack and leave the normal and specular textures and it will use the vanilla albedos alongside your PBR textures just fine.

ShulkerSakura commented 9 months ago

Sorry about that I can't perfectly understand what you talking about. If you want to say that some textures are not came from vanilla and have a little bit cripple the original texture's baked lighting,these are products from VNR,SPBR is based on VNR but no secondary processing of the vanilla texture. In next release I'm gonna fix it and add the chirseled tuff which I forgot it in the last release XD.

andrwcrr commented 9 months ago

For SPBR did you generally intend to re-add the baked lighting that VNR removed?

ShulkerSakura commented 9 months ago

Nope,I don't edit the vanilla textures because I'm not good at this.

andrwcrr commented 9 months ago

I think I'm overcoming the language barrier now, so from what I understand, you did not change any of the vanilla textures from VNR when making SPBR?

ShulkerSakura commented 9 months ago

I changed a little,But that because at that time I'm a new comer in resoucepack development, when I meet some problem that I can't figure it out I may change some pixels in the texture.

andrwcrr commented 9 months ago

do you have a discord/ discord server where we can communicate more conveniently because i am interested in this resource pack's development

ShulkerSakura commented 9 months ago

Nope bro SPBR have no any official chat app group/server.

Verix commented 2 months ago

Nope bro SPBR have no any official chat app group/server.

有没有粉丝qq/微信群呢?

ShulkerSakura commented 2 months ago

Nope bro SPBR have no any official chat app group/server.

有没有粉丝qq/微信群呢?

现在有了,Q:130950489