Problem filling the gear piece mold

Shurgent / TFCTech

TFCTech - Addon for TerraFirmaCraft. Custom integration and additional items for TFC + Tech-mods fusion. Base for the TFCTech Modpack (in future).

GNU General Public License v3.0

11 stars 18 forks source link

Problem filling the gear piece mold #19

Open wormzjl opened 7 years ago

wormzjl commented 7 years ago

If I take the mold out before the filling is completed then I'll get something like this, but the metal i'm using is copper It can be put back into the vessel to become completely filled through

Also it seems that I can't make gears other than copper

Shurgent commented 7 years ago

This is weird. The error is reproduced. I'll try to figure out where I screwed up...

Shurgent commented 7 years ago

So... As usual, the problem is that the ContainerLiquidVessel is hard-coded using four metals: Copper, Bronze, Bismuth Bronze and Black Bronze... https://github.com/Deadrik/TFCraft/blob/master/src/Common/com/bioxx/tfc/Containers/ContainerLiquidVessel.java#L144 I'm confused ... Apparently I'll have to inherit this class and create my own ... I do not know whether I want this. I'm running out of fuse, I'm tired of bumping into such things ... It's easier, probably, to fork TFC and write my own than to put crutches every time... Most likely, I will have to create my own Vessel to replace the original one...

wormzjl commented 7 years ago

Or just ASM it?

Shurgent commented 7 years ago

I do not have the skills of using ASM. But, apparently, I have to deal with this framework...

wormzjl commented 7 years ago

This mod has added some molds and works well http://terrafirmacraft.com/f/topic/8401-tfc-079290130terramisc-random-stuff-and-things-for-tfc/ Maybe you can take a look at what he did

Shurgent commented 7 years ago

I don't see a link to the source code. The search on GitHub did not bring any results.

wormzjl commented 7 years ago

no it's not open source, but it's java :P might ask him directly?