ShusenTang / Dive-into-DL-PyTorch

本项目将《动手学深度学习》(Dive into Deep Learning)原书中的MXNet实现改为PyTorch实现。
http://tangshusen.me/Dive-into-DL-PyTorch
Apache License 2.0
18.17k stars 5.38k forks source link

word2vec章节二次采样处感觉弄错了吧 #89

Closed orangerfun closed 4 years ago

orangerfun commented 4 years ago

bug描述 word2vec章节二次采样处感觉弄错了吧

def discard(idx):
 return random.uniform(0, 1) < 1 - math.sqrt(1e-4 / counter[idx_to_token[idx]] * num_tokens)

是不是改改成

    return random.uniform(0, 1) < 1-math.sqrt(t/(counter[idx_to_token[idx]]/num_tokens))

版本信息 pytorch: torchvision: torchtext: ...

ShusenTang commented 4 years ago

a / b * c = a / (b / c)