mini music player improvement

Shuvayatra / migration-android-new

1 stars 0 forks source link

mini music player improvement #124

Open umuieme opened 7 years ago

umuieme commented 7 years ago

[x] show only title and play/pause at first
[x] show image for podcast on mini player
[x] show seekbar when click on mini player

benloks commented 7 years ago

@rakeeb11 there are other issues still remaining with the mini media player:

[x] after playing audio post (not radio), player does not stay open when pressing "back"
[x] if audio post is playing, not able to start playing radio episode until you close the player.

rakeeb11 commented 7 years ago

will have a look at it ASAP

rakeeb11 commented 7 years ago

@benloks I've solved the first issue, but could not reproduce the second issue you mentioned.

benloks commented 7 years ago

@rakeeb11 sorry it's difficult for me to test right now because I am shaky wifi. You may be right about the second issue. But could you take a look at the radio player again? It seems like there might be other problems with it - though maybe you already solved them. E.g. in the build I have installed, I cannot select a radio episode to play... it just auto-plays the first one and selecting other episodes does not work. Please confirm if this is reproducible.

rakeeb11 commented 7 years ago

@benloks you're experiencing this because of the shaky internet.

The way the media player is built right now does not acknowledge user selection right away, it waits for the device to load all the necessary information it needs to play the podcast.

I'll tweak this process so that the user selection is acknowledged right away.

Thanks Ben.