Shuzhengz / TPFanCtrl2

ThinkPad Fan Control 2 (Dual Fan) for Windows 10 and 11
The Unlicense
290 stars 24 forks source link

Smart Mode keeps fan on during hibernate #21

Closed mjiderhamn closed 1 year ago

mjiderhamn commented 2 years ago

Describe the bug If running TPFanCtrl2 in Smart Mode and then putting the computer in hibernation mode, the fan keeps running. This in turn means the battery is drained while hibernating.

To Reproduce Steps to reproduce the behaviour:

Expected behaviour Fan is turned off during hibernation, as it is without TPFanCtrl2 running.

Desktop (please complete the following information):

Shuzhengz commented 2 years ago

Hmm that's weird. Thanks for bringing it up, I'll definitely look into it

Shuzhengz commented 2 years ago

The fans turn off for me during hibernate on smart (also on Windows 10 21H1, ThinkPad X1 Extreme). I think it might have something to do with Lenovo's easy resume feature, or just newer Thinkpad models' EC.

I'll try adding power mode change detection and see if it helps.

mjiderhamn commented 2 years ago

Can I help by supplying any logs?

Shuzhengz commented 2 years ago

I don't think power changes or window closing actions are implemented yet, so they won't show up on logs. Thanks tho!

Shuzhengz commented 2 years ago

cool try this

tpfc.zip

mjiderhamn commented 2 years ago

cool try this

tpfc.zip

Fans still running while hibernating with this one also.

0xbb commented 2 years ago

Maybe unrelated: My X1 Extreme Gen 4 also keeps the fan spinning in standby (sleep) even without tpfc. I usually turn off the modern standby on newer Thinkpads and this problem goes away: https://www.drwindows.de/xf/attachments/anmerkung-2020-02-21-050059-jpg.214555/ https://www.drwindows.de/xf/attachments/anmerkung-2020-02-21-050017-jpg.214554/

Shuzhengz commented 2 years ago

hmm this might be a lenovo BIOS problem then, because the program closes to the BIOS once it detects the computer is entering sleep / hibernation (it can write fan level 0 into EC, but that's still going to be overridden by lenovo BIOS)

Shuzhengz commented 2 years ago

@mjiderhamn maybe try this config, I tuned the fan curve so the fan shuts off earlier than usual, and ramps up quicker. TPFanControl.zip

mjiderhamn commented 2 years ago

@0xbb , with Sleep State mode Linux set in UEFI, fans turn off in hibernation mode even with TPFC running. In Windows mode, fans stop without TPFC but keep spinning with TPFC.

Shuzhengz commented 1 year ago

closing issue due to inactivity, and problem is caused by microsoft's inplementation of modern standby (linux sleep mode uses stage 3 sleep so it doesn't do weird stuff)