Master - Githubissues

ShwetKhatri2001 / AR-Webstore

Webstore built to showcase photorealistic 3D digital objects in AR

https://ar-webstore.netlify.app/

MIT License

52 stars 102 forks source link

Master #215

Closed panditshivammishra closed 6 months ago

panditshivammishra commented 6 months ago

Changes proposed

I have added some animation to card that catch it in a frame

Check List (Check all the applicable boxes)

[Done ] My code follows the code style of this project.
[not ] My change requires changes to the documentation.
[done ] I have updated the documentation accordingly.
[ done] All new and existing tests passed.

netlify[bot] commented 6 months ago

Deploy Preview for ar-webstore ready!

Name	Link
Latest commit	4dbc24c30cc9518ba88b4d44b9c3393aac50c544
Latest deploy log	https://app.netlify.com/sites/ar-webstore/deploys/6599d685bfc8df00086ab082
Deploy Preview	https://deploy-preview-215--ar-webstore.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShwetKhatri2001 commented 6 months ago

I don't think it's a good idea to have it on an e-commerce platform. There are few more type of animations you may try. Also, mention the issue for which you're raising this PR.