search

ShwetKhatri2001 / AR-Webstore

Webstore built to showcase photorealistic 3D digital objects in AR
https://ar-webstore.netlify.app/
MIT License
58 stars 101 forks source link

added docker functionality #228

Closed Girishbari closed 8 months ago

Girishbari commented 8 months ago
Fixes #218

Added dockerfile, there will some change required in readme file such project can be run docker run -p 3000:3000 ar-webstore

netlify[bot] commented 8 months ago

Deploy Preview for ar-webstore ready!

Name Link
Latest commit 32c836090270c6acb9f1d82c150d1e02810b3c46
Latest deploy log https://app.netlify.com/sites/ar-webstore/deploys/65b0bc3caf1f730008825108
Deploy Preview https://deploy-preview-228--ar-webstore.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShwetKhatri2001 commented 8 months ago

So, is it just a single command or some more things required in the docker-based setup since we need to update the documentation accordingly. Also, better if you can only do it.

Girishbari commented 8 months ago

currently it is just one command but I did suggest one more thing that you can do

  1. make an account on docker hub (similar to GitHub but only for images)
  2. we'll upload this project there, in that sense one even don't require to clone the project, one can use docker pull to get the project from there
  3. this will help us to deploy project vercel or on railway
Girishbari commented 8 months ago

ping me when you're ready

ShwetKhatri2001 commented 8 months ago

I will surely see this and get back to you in a few days. You may start with other fixes/enhancements in the meantime if you like to.

ShwetKhatri2001 commented 8 months ago

The project's image is deployed on the docker hub. It will work for the Dockerfile you've added. Include a .dockerignore file having file/folder names that are not required.

Test it and write good documentation for this setup. Mention these commands with some description in README.md, docker -v to check docker installed locally successfully docker pull shwetkhatri2001/ar-webstore docker images to check an image exists with the name 'shwetkhatri2001/ar-webstore' docker run -p 3000:3000 shwetkhatri2001/ar-webstore

Girishbari commented 8 months ago

sure