ShwetKhatri2001 / AR-Webstore

Webstore built to showcase photorealistic 3D digital objects in AR
https://ar-webstore.netlify.app/
MIT License
52 stars 102 forks source link

feat: added annotations using MODEL-VIEWER #244

Closed Girishbari closed 5 months ago

Girishbari commented 5 months ago

Fixes #111

Added annotation part on each product using model-view

Changes proposed

[x] - Correct; marked as done

Check List (Check all the applicable boxes)

netlify[bot] commented 5 months ago

Deploy Preview for ar-webstore ready!

Name Link
Latest commit fa28dde4f634ac74ff45ed02edafbdbeb70e0fc7
Latest deploy log https://app.netlify.com/sites/ar-webstore/deploys/65b769c1fedc1a0008d2e810
Deploy Preview https://deploy-preview-244--ar-webstore.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShwetKhatri2001 commented 5 months ago

Great work @Girishbari !

Just want to confirm if you can achieve this small feature as described in the issue description.

On clicking on the annotations the camera should target that position as shown in this cameraViews example. After getting the code from the editor above you need to change it and add event listeners as shown in this example.

Girishbari commented 5 months ago

okay, will do

Girishbari commented 5 months ago

I think this would do

https://github.com/ShwetKhatri2001/AR-Webstore/assets/38005544/33daa8df-aa03-4419-91f4-c716c693cc81

ShwetKhatri2001 commented 5 months ago

Yes, it's good that you're moving to that annotation. but can you zoon in to that specific annotation ?

ShwetKhatri2001 commented 5 months ago

Will you push some new changes ?

Girishbari commented 5 months ago

No I guess