ShwetKhatri2001 / AR-Webstore

Webstore built to showcase photorealistic 3D digital objects in AR

https://ar-webstore.netlify.app/

MIT License

52 stars 102 forks source link

Improved navbar in mobile view #251

Closed KeyurGK closed 4 months ago

KeyurGK commented 5 months ago

Fixes #200

Changes proposed

Before :

The navbar transitioned from the top as a drop-down, covering the product list giving the user a bad UX.

After :

The new navbar in mobile screens, transitions from the right side.
The navbar remains fixed, as the user scrolls through the product list.

https://github.com/ShwetKhatri2001/AR-Webstore/assets/56074740/141815b3-0830-4282-b46e-d79ae5f10d51

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] My change requires changes to the documentation.
[X] I have updated the documentation accordingly.
[X] All new and existing tests passed.

netlify[bot] commented 5 months ago

Deploy Preview for ar-webstore ready!

Name	Link
Latest commit	a7b1335611ea675269c4989c433b4a1779637853
Latest deploy log	https://app.netlify.com/sites/ar-webstore/deploys/65d21bd26b187e00089cb56e
Deploy Preview	https://deploy-preview-251--ar-webstore.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShwetKhatri2001 commented 5 months ago

Can you please make these two small changes. It can be merged after that.

Close the sidebar when any link present inside is clicked.
Reduce the font size of link labels ( text ) probably to the previous size.

KeyurGK commented 4 months ago

Can you please make these two small changes. It can be merged after that.

Close the sidebar when any link present inside is clicked.

Reduce the font size of link labels ( text ) probably to the previous size.

Updated with recommended changes @ShwetKhatri2001 :

https://github.com/ShwetKhatri2001/AR-Webstore/assets/56074740/e1d1b690-3def-401b-9ec0-3c41b3b36d6a