search

ShwetKhatri2001 / AR-Webstore

Webstore built to showcase photorealistic 3D digital objects in AR
https://ar-webstore.netlify.app/
MIT License
52 stars 102 forks source link

feat: variant selection #255

Closed IrfanshaikH-7 closed 4 months ago

IrfanshaikH-7 commented 4 months ago

Fixes Issue

Related issue: #113 Closes #113

Changes proposed

added a feature where users can change variants of products if available - without interfering with other products in map.

note

I haven't worked on UI. if we could conclude this features functionally I 'll do that then.

Check List (Check all the applicable boxes)

netlify[bot] commented 4 months ago

Deploy Preview for ar-webstore ready!

Name Link
Latest commit cd105c5ba4d9e1d48b15d2b26802ef90620a4402
Latest deploy log https://app.netlify.com/sites/ar-webstore/deploys/65da160dbc012100086f6f94
Deploy Preview https://deploy-preview-255--ar-webstore.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShwetKhatri2001 commented 4 months ago

Amazing work @IrfanshaikH-7 ! I hope it will work on all models having variants dynamically. but to test that, it will be better if you can have two more variants in the other 3 models as I described in https://github.com/ShwetKhatri2001/AR-Webstore/issues/113#issuecomment-1953015074.

A few more things you can update are some UI issues.

image

Just fix these and I will merge the PR for Hard.

ShwetKhatri2001 commented 4 months ago

Looks better now. Can you see this one last remaining thing? It will make the PR valid for Hard level.

It will be better if you can have two more variants in the other 3 models as I described in https://github.com/ShwetKhatri2001/AR-Webstore/issues/113#issuecomment-1953015074.

IrfanshaikH-7 commented 4 months ago

Looks better now. Can you see this one last remaining thing? It will make the PR valid for Hard level.

It will be better if you can have two more variants in the other 3 models as I described in #113 (comment).

its giving me .glb file. how do I get the .usdz

IrfanshaikH-7 commented 4 months ago

Looks better now. Can you see this one last remaining thing? It will make the PR valid for Hard level.

It will be better if you can have two more variants in the other 3 models as I described in #113 (comment).

please review my PR now i have added two new models with vaients