ShwetKhatri2001 / Swetify-Music

Welcome to Swetify-Music where you are going to groove on your favourite songs
https://swetify.netlify.app/
24 stars 66 forks source link

[Feature] <Uploading songs feature> #103

Open JoydeepMallick opened 8 months ago

JoydeepMallick commented 8 months ago

Description

In reference to the chat https://github.com/ShwetKhatri2001/Swetify-Music/issues/95#issuecomment-1883151200

@ShwetKhatri2001 how do you propose to add this feature, I mean will there be another option on sidebar where we can upload songs and then select a playlist to put it into or create a new playlist for the same.

Post adding the feature we can simply run the script post upload of song and before it gets saved in playlist which can be termed as processing uploads please wait but one doubt is that how will it be stored, I am a little confused regarding it.

Well this will be completely for as of now be for temporary user who visits website but will vanish as soon as he/she refreshes page, is there some way where in we can redirect his uploads to Github🤔 or do we need to use databases to store songs since upload feature without database will be temporary.

Screenshots

One issue I noticed recently is that while the liked music section seems not to work when we like any music.

Checklist

ShwetKhatri2001 commented 8 months ago

It's still a good to have feature since we need to have a database to save data of each song (especially the audio and poster image) and before having it for new songs we need to have our existing songs stored in that database.

As a first step, we can consider our files uploaded to a database that can provide URLs for all poster and audio files and update our JSON files having those URLs. In this way, we can also first reduce the size of our project.

What are your thoughts on this and would you like to contribute to this? I also have some thoughts then for new songs to be uploaded.

Paarisha1 commented 7 months ago

Can I contribute in this

ShwetKhatri2001 commented 7 months ago

Sure, Let me know what you are interested in contributing.

Paarisha1 commented 7 months ago

As you have mentioned that I will create a upload button and simply by on click one can upload songs

ShwetKhatri2001 commented 7 months ago

Okay, go ahead. You can add a frontend section for that at the bottom of the home page. Make sure you use our theme colors and font. Assigning you to make your proposed changes.

Paarisha1 commented 7 months ago

Sure

Paarisha1 commented 7 months ago

I have added an upload button in the sidebar but to upload the data there is no backend logic to store songs data currently present in the project, so should I create PR with only frontend part of upload feature?

ShwetKhatri2001 commented 7 months ago

Yes, you can.

ShwetKhatri2001 commented 7 months ago

@Paarisha1 Reminding you SWOC contribution period is ending on 28 Feb if you're contributing as part of it.