ShyamKrishna33 / pe

0 stars 0 forks source link

Changing correctness of an attempt does not throw an error #5

Open ShyamKrishna33 opened 2 months ago

ShyamKrishna33 commented 2 months ago

When the correctness of an attempt is changed manually and the chatbot is started, no error is triggered.

Here, 2 inputs are changed to true from false.

image.png

The result still stays as the previous value, but the details of the attempt show incorrect answers.

Here, the questions where the correctness is altered, the answers show it as correct.

image.png

soc-se-bot commented 2 months ago

Team's Response

Thanks for pointing this out. Yes, checks should have been in place to prevent corrupted data.

Duplicate as essence of reported bug is the game allowing for altered save file.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Changing the option to an invalid option does not throw error

When the option is changed to an invalid option:

image.png

There is no error thrown.


[original: nus-cs2113-AY2324S2/pe-interim#1755] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

Thanks for pointing this out. However, we believe this to be deliberate sabotage. It does not cause the product to be unusable and the program continues to function as it should.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The bugs are not duplicate of one another as the current bug will just create a logical inconsistency among the data displayed to the user while the bug reported as original creates an impossible event like having an option e to a question with 4 options. Also considering the fact that fixing one does not automatically fix the another, they are not duplicates.

image.png


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]