search

ShyamKrishna33 / pe

0 stars 0 forks source link

Removing values from storage #7

Open ShyamKrishna33 opened 2 months ago

ShyamKrishna33 commented 2 months ago

If all the entries in the correctness row are removed from the storage no error is thrown.

image.png

The overall result shows 30% but the details cannot be seen because of a wrong error - index out of bounds. image.png

File corruption should be handled in all the cases.

soc-se-bot commented 2 months ago

Team's Response

Thanks for pointing this out. Yes, checks should have been in place to prevent corrupted data.

Duplicate as essence of reported bug is the game allowing for altered save file.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Changing the option to an invalid option does not throw error

When the option is changed to an invalid option:

image.png

There is no error thrown.

[original: nus-cs2113-AY2324S2/pe-interim#1755] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

Thanks for pointing this out. However, we believe this to be deliberate sabotage. It does not cause the product to be unusable and the program continues to function as it should.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Considering the fact that fixing one does not automatically fix the another, they are not duplicates.

image.png

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** It is not considered as deliberate sabotage as it falls within the constraints of the tp. ![image.png](https://raw.githubusercontent.com/ShyamKrishna33/pe/main/files/1c37cc63-375c-4b1e-b942-31c26dc61e58.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** No explanation provided by the team for the reduction in severity. I feel that this is of severity.medium because when the file is corrupted by any means there is no notification to the user and the expected behaviour is different from the UG.