search

Shylight / healthEstimate

MIT License
4 stars 12 forks source link

"Hit Points Attribute" not working. #54

Closed theMagius0 closed 2 years ago

theMagius0 commented 2 years ago

Foundry Version: 9.242 Game System: Fallout 2d20 9.0.0 Health Estimate Version: 2.6.20 Browser: Firefox 96.0.1

The Fallout Game System uses "health" instead of "hp" for determining hit points in fallout-main\lang\en.json as follows:

"FALLOUT.HEALTH": { "health": "Health", "max": "Max Health", "current": "Current Health" }

So, in "Hit Points Attribute" of Health Estimate Game Settings, I typed in:

health

And I'm receiving this error in F12 debug:

Health Estimate | Error on HealthEstimate._getEstimation(). Token Name: Trader / Caravan Merchant . Type: npc TypeError: hp is undefined fraction generic.js:10 getFraction logic.js:87 _getEstimation logic.js:289 _handleOverlay logic.js:280 initHooks logic.js:253 _call foundry.js:294 callAll foundry.js:253 _onHoverIn foundry.js:21708 _onHoverIn foundry.js:38715 callback foundry.js:24060 _handleMouseOver foundry.js:24177 emit index.js:181 dispatchEvent interaction.min.js:8 processInteractive interaction.min.js:8 onPointerMove interaction.min.js:8

Correct me if I'm wrong here, but...

Shouldn't the field marked "Hit Points Attribute" attempt to replace the undefined "hp" in the debug with "health"?

Is there something I'm missing?

theMagius0 commented 2 years ago

Wrong author. Apologies.